Add support for WAV files with appended metadata#113
Open
nateranda wants to merge 5 commits intodhowden:masterfrom
Open
Add support for WAV files with appended metadata#113nateranda wants to merge 5 commits intodhowden:masterfrom
nateranda wants to merge 5 commits intodhowden:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some software like Audacity, MP3tag, and Serato DJ store metadata in WAV files by appending ID3 tags in a new RIFF chunk. Some discussion on this here.
I added support by seeking to the start of the appended metadata, then recalling the parent function. An earlier commit implements ID3-appended WAV support without recursive functions if they should be avoided, but the current implementation supports all metadata types. I am happy to write tests for this as well.